The Docker files should be in a 8.0/ directory.

The Docker files should be in a 8.0/ directory.

They are.

Ha! I missed that.

In that case LGTM

You should enable cancelling old builds on new pushes on travis. I force pushed a bit, and the queue is real right now 😭

https://blog.travis-ci.com/2017-03-22-introducing-auto-cancellation

I would if I had the access to do that ;-)

Someone from the build group should be able to enable that for us.

Should I close #410?

Sure.

Wait, is 7.x a completely abandoned branch now?

Wait, is 7.x a completely abandoned branch now?

https://github.com/nodejs/LTS/blob/4af640885c5888894348ace2b15942e8989494e4/README.md

An odd-numbered major release will cease to be actively updated when the subsequent even-numbered major release is cut.

Not really sure if that means "completely abandoned", though...

Btw, can one of you cancel some of the builds here? https://travis-ci.org/nodejs/docker-node/pull_requests (bonus is activating auto cancellation 🙂)

@SimenB thanks, it is indeed abandoned then.

I think the Yarn version should be updated too in this PR, according to the (not yet officially accepted) policy in #393

Were we also going to update Alpine for 8.x or was there a different plan for that? Either way, that can probably be handled separately.

Yes, Alpine should also be updated (probably to 3.6) according to the discussion in #399

I think the Yarn version should be updated too in this PR

I chose not to update it to keep it consistent between images. That doesn't really make sense though, the npm version is already different. Want me to update it?

I'd vote we merge this PR as is and make a separate ones for upgrade of Alpine and Yarn.

I chose not to update it to keep it consistent between images.

Running ./update.sh 8.0 should "Do the right thing":tm: and only update it for 8.x.

I'm ok with doing Yarn and Alpine separately in this case, but in general think they should be handled in a single PR, atomically.

CI is green, but it doesn't seem connected to the latest commit in this PR... https://travis-ci.org/nodejs/docker-node/builds/237656473

@SimenB looks like the commit that CI built is the merge commit: 8e936c8

💤

CI is confused, I force pushed the same commit now.

EDIT: Didn't help at all... I have no idea, just merge it? The same diff was green even if github/travis is a bit confused

I checked locally, it's all good. Merging.

Great! Will this be pushed to the docker registry, or should yarn and alpine be updated first?

EDIT: PR for the former: #412, latter: #413

Thanks a lot @SimenB. I'll merge them as soon as the builds finish. I have prepared a PR to Docker Hub. Hopefully will get this one out buy by the end of the day.